search

mizzao / meteor-sharejs

Meteor smart package for transparently adding ShareJS editors to an app
MIT License
225 stars 53 forks source link

Fix error loading browserchannel/BCSocket #85

Closed rajit closed 7 years ago

rajit commented 7 years ago

Unfortunately 0.10.1 contains a bug in loading BCSocket from the node module browserchannel that share depends on.

I didn't spot it because I only tested my pull request as a local package in <project>/packages. I've now tested this modification with a published package and it works correctly and fixes the issue.

FYI 0.10.1 does not work at all as it is currently published.

rajit commented 7 years ago

It's not clear to me why Travis is failing. When I run the tests locally there are no issues.

DavidSichau commented 7 years ago

Thanks for your effort. Travis is always falling, locally they work and I have no idea why.

I am currently looking at replacing sharejs with sharedb which would then also allow richt text editing.

rajit commented 7 years ago

Brilliant, thanks!

Replacing with ShareDB would be excellent.