search

mkaply / cck2wizard

CCK2
Mozilla Public License 2.0
46 stars 9 forks source link

removeDefaultBookmarks seems not to work anymore on FF57 #69

Closed llelectronics closed 6 years ago

llelectronics commented 6 years ago

It seems like removeDefaultBookmarks is not working for FF57 anymore. It leaves "Getting Started" in the bookmarks toolbar. Same cck2.cfg worked fine in FF56 and before.

mkaply commented 6 years ago

Have you updated to the latest CCK2?

llelectronics commented 6 years ago

Yes cck2 modules are on latest version.

mkaply commented 6 years ago

I've checked on this and it's working for me. Might be a timing issue.

I'l continue to investigate.

shadeslayer commented 6 years ago

I investigated this and turns out the userAgentLocale is undefined in our deployment of firefox 58 This line here https://github.com/mkaply/cck2wizard/blob/master/cck2/modules/CCK2.jsm#L663 seems to be the culprit.

However, general.useragent.locale is defined as en-us in about:config, so perhaps it's only undefined on the first run?

shadeslayer commented 6 years ago

So I've worked around it as such https://github.com/netrunner-common/netrunner-settings-firefox/commit/20e08bf8937155c7690b7437fc11beadbac44260

mkaply commented 6 years ago

FYI, I went a different route. This should be good in Firefox 60 with latest CCK2.