HW3 - Twitter Client - Githubissues

Mark, I see that error sometimes, I believe it is a harmless error despite what it's claiming. Good job on the homework overall.

The constraints in TweetCell are correct. Constraints look good for TweetViewController and Compose as well.
Did you notice that your timeline contained tweets that were misaligned? It's because you defined a property called textLabel which already exists in the UITableViewCell. The base class is configuring the frame of textLabel. You should avoid using textLabel, imageView, titleLabel, subtitleLable in custom cell classes.
Avoid creating methods that start with init like initWithTweet unless it's actually a constructor. By convention, init methods are always called together with alloc. Instead of initWithTweet, you could have created a tweet property and configured the views in the custom setter.
Don't download images synchronously like this:

NSURL * imageURL = [NSURL URLWithString:tweet.profilePicUrl];
NSData * imageData = [NSData dataWithContentsOfURL:imageURL];
UIImage * image = [UIImage imageWithData:imageData];

[self.profileImageView setImage:image];

Instead, do this:

// #import "UIImageView+AFNetworking.h"  <-- requires this category
[self.profileImageView setImageWithURL:[NSURL URLWithString:tweet.profilePicUrl]];

In heightForRowAtIndexPath, don't alloc a cell just to get the height, that will be very slow.
Compose views are usually presented modally, not on the navigation stack.
Good job reloading the twitter feed after the compose. A slightly better alternative would be to pass the created tweet back into the feed locally, so it'll be there immediately even with slow internet.
There's no way to delete a retweet or favorite.
Good job implementing pull to refresh.
Consider implementing infinite scroll loading.

The main takeaways for this homework were:

How to handle dynamically sized rows in table views.
How to implement and debug Auto Layout in the Tweet Cell, Compose view, and Tweet view.
How to implement nav stack and modal navigation.
How to augment a networking client.
How to augment a model, adding serialization/deserialization code, and formatting code.

Here's my checklist of things I'm looking at when I'm reviewing this project.

Is the Objective-C code styling consistent with standards?
Did you augment the API client with the methods for updating status, reply, retweet, favorite? Note that there is a separate endpoint for removing a retweet or favorite.
Did you augment the Tweet model? Note that for the embedded user, you should instantiate a User object and have the User class do the deserialization, instead of navigating to user.screen_name in the Tweet model.
Were the Auto Layout constraints correct for all the views?
Was the navigation implemented correctly either manually or via segues?
Was pull to refresh implemented?
Was infinite scrolling implemented?

mkim177-zz / ios_twitter

HW3 - Twitter Client #1