search

mklement0 / ttab

macOS and Linux CLI for opening a new terminal tab/window, optionally with a command to execute and/or display settings
285 stars 15 forks source link

Install fails on linux #19

Closed ChariseWalraven closed 6 years ago

ChariseWalraven commented 6 years ago

Hi there,

I know this is a module for mac, but could you please not throw an exception on installation when the OS is not a Mac?

Whenever I try to install my dependencies, I cannot complete the installation, because it throws me an error in the process of installing because I'm not on a mac and then exits the installation.

I am definitely sure this is ttab, because it works fine when i remove the dependency on a ubuntu distro and then intall the dependencies again.

image

Maybe it's possible to show an info message instead of an outright error and just skip the installation if the system is not a Mac?

mklement0 commented 6 years ago

ttab's package.json file by design indicates that the package is only supported on macOS:

https://github.com/mklement0/ttab/blob/a2f01f1c048c62cb6b28ad8085fc222f2659311e/package.json#L6-L8

I'm not familar with yarn, but it sounds like if you reference ttab from your project's optional dependencies ("optionalDependencies") - just as fsevents appears to be declared as in yoru screen shot - the problem should go away.

yarn install --ignore-platform may work too, though it may be too blunt a tool.

Let me know if that doesn't help.