WIP: Tab title not being applied

mklement0 / ttab

macOS and Linux CLI for opening a new terminal tab/window, optionally with a command to execute and/or display settings

285 stars 15 forks source link

WIP: Tab title not being applied #68

Closed xithalius closed 11 months ago

xithalius commented 1 year ago

Related to #44, I looked into ANSI escape sequences a bit and (https://github.com/jonathaneunice/iterm2-tab-set/blob/master/tabset.js#L450) but I don't think it's related to the issue I'm having. I'm a Applescript newb but this change managed to set a new tab's title when executing ttab -t "How Green Was My Valley" using iTerm2, where it previously wouldn't.

xithalius commented 1 year ago

Is it okay to re-order the execution of setting the new tab's title and using a pre-defined delay before setting it?

mklement0 commented 11 months ago

@xithalius, I apologize - I've been meaning to get around to this.

Glancing at your PR, it's not clear to me how it would solve the problem.

The idea behind CMD_DELAY was to only apply it once, and only if requested by the user, via -l

mklement0 commented 11 months ago

I'll take a closer look, however.