search

mkristian / jbundler

bundler support for jars for jruby
MIT License
210 stars 39 forks source link

Fix Thor inheritance when using Bundler >= 1.9.0 #60

Closed camertron closed 9 years ago

camertron commented 9 years ago

Inheriting directly from Thor in JBundler::CLI doesn't work with bundler >= 1.9.0 because bundler's Thor version has been namespaced. In other words, in lib/bundler/vendored_thor/thor.rb, Bundler::Thor is defined instead of just Thor (as in previous versions). This change breaks JBundler.

mkristian commented 9 years ago

merged manually - thanx

camertron commented 9 years ago

Cool, thanks @mkristian. Which branch did you merge this into?

mkristian commented 9 years ago

master branch

did work on it myself but didn't reach the inheritance yet. had a problem with this vendored thor in bin/jbundle already. still testing on my side.