ml-explore / mlx

MLX: An array framework for Apple silicon
https://ml-explore.github.io/mlx/
MIT License
17.59k stars 1.02k forks source link

[BUG] ERROR: No matching distribution found for mlx>=0.x #1536

Closed Blaizzy closed 1 month ago

Blaizzy commented 1 month ago

Describe the bug My GH tests are failing because they can't install mlx.

To Reproduce Workflow yaml:

name: Test PRs

on:
    pull_request:
        branches:
            - main

jobs:
    test:
        runs-on: macos-14

        steps:
        - name: Checkout code
          uses: actions/checkout@v2

        - name: Set up Python
          run: |
            brew install python@3.10
            python3 -m venv env
            source env/bin/activate

        - name: Run style checks
          run: |
            pip install pre-commit
            pre-commit run --all
            if ! git diff --quiet; then echo 'Style checks failed, please install pre-commit and run pre-commit run --all and push the change'; exit 1; fi

        - name: Install dependencies
          run: |
            pip install pytest
            pip install -e .

        - name: Run Python tests
          run: |
            cd mlx_vlm/
            pytest -s ./tests

Requirements.txt:

mlx>=0.18.1 

Expected behavior I expect the dependencies to install normally as in the past.

Desktop (please complete the following information):

Additional context Add any other context about the problem here.

awni commented 1 month ago

Probably this is because we don't have a python 3.8 distribution anymore.

You should either setup the venv with the 3.10 distribution or use the 3.10 distribution you install directly:

            /opt/homebrew/bin/python3.10 -m venv env
Blaizzy commented 1 month ago

Thanks, I fixed it with:

name: Test PRs

on:
  pull_request:
    branches:
      - main

jobs:
  test:
    runs-on: macos-14

    steps:
      - name: Checkout code
        uses: actions/checkout@v4

      - name: Set up Python
        uses: actions/setup-python@v5
        with:
          python-version: '3.10'

      - name: Install MLX
        run: |
          pip install mlx>=0.15

      - name: Install pre-commit
        run: |
          python -m pip install pre-commit
          pre-commit run --all
          if ! git diff --quiet; then
            echo 'Style checks failed, please install pre-commit and run pre-commit run --all and push the change'
            exit 1
          fi

      - name: Install package and dependencies
        run: |
          python -m pip install pytest
          python -m pip install -e .

      - name: Run tests
        run: |
          pytest -s .