Closed myedibleenso closed 1 year ago
Can we update the img2mml pipeline to not have extra whitespace within an element? That is, instead of producing <mo> + </mo>
, it would be better to produce <mo>+</mo>
. Otherwise the parsing becomes more involved, for little benefit.
Actually, on further thought, I think we should update the MathML parser to handle the whitespace, since it seems like it will be rendered properly on the web.
Actually, on further thought, I think we should update the MathML parser to handle the whitespace, since it seems like it will be rendered properly on the web.
This may impact plans for https://github.com/ml4ai/skema/issues/291
Are you changes also going to address tolerance for comments? If so, I think I can close #291 .
@myedibleenso - I don't plan to address comments with these changes, since the img2mml pipeline doesn't produce them.
Closed by https://github.com/ml4ai/skema/pull/290 . I think this puts the ball back into img2mml 's court. 🤞 that the new models address some of the issues we're seeing!
The current version of the
/mml/amr
endpoint is unable to handle the following pMML produced from Lotka-Volterra equation images by the/image/mml
endpoint:A self-contained (non-working) example is provided at the end of this notebook: https://github.com/ml4ai/ASKEM-TA1-DockerVM/blob/c2404523e7bb0a0af7f773ac95881bb8f1700da7/equations-rest/notebooks/eqn2amr.ipynb