search

ml5js / ml5-next-gen

Repo for next generation of ml5.js: friendly machine learning for the web! 🤖
https://ml5js.org/
Other
95 stars 23 forks source link

fixed the video argument problem in the BodySegmentation constructor #213

Closed agrshch closed 1 month ago

agrshch commented 1 month ago

Fixes #212

Although I'm not entirely sure if this.video property is actually necessary since the detection methods ask for the image/video as an argument

UPD. It turned out to be redundant, so I removed it.

ziyuan-linn commented 1 month ago

@shiffman I think we can have this change tag along for tomorrow's release. Thank you again @agrshch!

shiffman commented 1 month ago

@all-contributors add @agrshch for bug and code

shiffman commented 1 month ago

Thank you @agrshch this is such a great catch, much appreciated! We're doing a new release and this will be included!

agrshch commented 1 month ago

@shiffman @ziyuan-linn thank you so much for all your work!

shiffman commented 1 month ago

@all-contributors add @agrshch for bug and code

allcontributors[bot] commented 1 month ago

@shiffman

I've put up a pull request to add @agrshch! :tada: