search

ml5js / ml5-website-v02-docsify

This repository is a work-in-progress website, containing documentation and reference materials for the ml5.js library models.
https://docs.ml5js.org/
Other
1 stars 11 forks source link

Added footer & changed sidebar toggle behavior #86

Closed alanvww closed 5 months ago

alanvww commented 5 months ago

This PR is to add a footer and I also tried to change the behavior of the sidebar toggle to the right side when it is opened. In the previous version, the toggle will overlapped with the menu items. This is the preview: CleanShot 2024-06-15 at 16 21 53 @MOQN @QuinnHe @myrahsa Please feel free to give me some feedback on this!

netlify[bot] commented 5 months ago

Deploy Preview for ml5-next-gen-docs ready!

Name Link
Latest commit 4f0b44162a841fada33df4ff6cbec275213304ae
Latest deploy log https://app.netlify.com/sites/ml5-next-gen-docs/deploys/666ef48d148c0e0008cc15dc
Deploy Preview https://deploy-preview-86--ml5-next-gen-docs.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

MOQN commented 5 months ago

@alanvww This is amazing! I have very minor feedback. Could you please align the text box with the line that I indicated in the image?

Screenshot 2024-06-16 at 1 05 28 PM
alanvww commented 5 months ago

@MOQN The new commit fixed the alignment! Also, I asked a few classmates in ITP while working on this, some of them think a different background color is easier to tell it is a footer and helps indicate that this is the end of the page. But feel free to let me know what you think!

MOQN commented 5 months ago

It looks fantastic!!! Merging it now. I also support the idea of adding the background color. I will adjust the color for consistency.