ml5js / ml5-website-v02-gatsby

A work-in-progress repo for the new website of ml5.js
https://ml5js.org/
MIT License
0 stars 9 forks source link

Added favicon, web manifest & og image #31

Closed alanvww closed 3 months ago

alanvww commented 3 months ago

Fixed #30 @QuinnHe @MOQN

netlify[bot] commented 3 months ago

Deploy Preview for ml5-next-gen ready!

Name Link
Latest commit 53317b7ec0965c117bc23652c99ac7cfc99cb874
Latest deploy log https://app.netlify.com/sites/ml5-next-gen/deploys/66ac39b744b3d50008a268c5
Deploy Preview https://deploy-preview-31--ml5-next-gen.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

QuinnHe commented 3 months ago

Thanks @alanvww ! Moon @MOQN , seems I don't have access to this repo. Maybe you can merge it :)

alanvww commented 3 months ago

Thanks @alanvww ! Moon @MOQN , seems I don't have access to this repo. Maybe you can merge it :)

I found a new issue with my implement of the metadata tag. Fixing it now.

alanvww commented 3 months ago

Issue fixed! Ready to merge :D @MOQN

MOQN commented 3 months ago

Thank you @alanvww! I will send modified images with rounded corners. I am merging this for now because it's better than having no favicon. :D

MOQN commented 3 months ago

@QuinnHe @alanvww, I've updated your role in this repo!

alanvww commented 3 months ago

Thank you @alanvww! I will send modified images with rounded corners. I am merging this for now because it's better than having no favicon. :D

I actually didn't notice this as an issue since almost all the browser and system extensions I use will mask the icons with an rounded square 😳. But let's fix it! Just hit me with an email.

MOQN commented 3 months ago

@alanvww updated images with rounded corners will be sent shortly!