Incompatibility with Firefox Extension "Last Tab Close Button" (running version 0.3.3)

[GoogleCodeExporter]

What steps will reproduce the problem?
1. Install both new-tab-jumpstart and Last Tab Close Button extensions
2. Open a new Firefox window
3. Close this window with middle click on tab, or clicking X button on tab 
itself

What is the expected output? What do you see instead?
The Last Tab Close Button extension allows the user to close the window by 
closing the tab itself, instead of clicking on the default Windows' close 
button (X on the top right of the window).  However, with both these 
extensions, when I close the last tab, the new-tab-jumpstart page automatically 
re-opens.

What version of the product are you using? On what operating system?
new-tab-jumpstart 0.5a5.4.3
last tab close button 0.3.3

Please provide any additional information below.
let me know if you have any other questions.  Thanks a lot for the great 
extension otherwise!  Hope it's fixable

Regards,

Peter

Original issue reported on code.google.com by khteprs...@gmail.com on 6 Jun 2011 at 8:02

[GoogleCodeExporter]

Sorry if you don't consider this a bug on your part, let me know if I should 
change this to a feature request or other type.  Also let me know if you think 
this is more relevant to the last tab close button extension developer .

Original comment by khteprs...@gmail.com on 6 Jun 2011 at 8:10

[GoogleCodeExporter]

Thanks for reporting, I'll investigate it, it could be any of them, or could be 
something else. I will get to it in next couple of days

Original comment by mlalevic@gmail.com on 7 Jun 2011 at 8:57

[GoogleCodeExporter]

It's definitely some conflict between new tab jumpstart and last tab close 
button. Will look into this further later today

Original comment by mlalevic@gmail.com on 10 Jun 2011 at 8:33

• Changed state: Accepted

[GoogleCodeExporter]

I've found what the issue is but unfortunately it has to be dealt with in Last 
Tab Close Button. Code there is checking whether about:blank is opened to 
perform close of the window or whatever it is configured to do. However that 
won't work because I'm intercepting opening of blank tabs to show New Tab 
Jumpstart so it never has about:blank url. I'll try to think of something but 
without Last Tab Close Button changed I'm not sure if I can do anything.

Original comment by mlalevic@gmail.com on 23 Jun 2011 at 11:58

[GoogleCodeExporter]

OK, thanks a lot, I'll notify the developer of Last Tab Close Button.  

I can't figure out how to close this issue, let me know if you need me to do 
anything to close out this issue.

Regards,

Peter

Original comment by khteprs...@gmail.com on 30 Jun 2011 at 3:39

[GoogleCodeExporter]

The only thing we could do is to fix the code for Last Tab Close Button. 
However, that's just a quick and ugly fix, if extension gets updated it will 
overwrite the changes. For a proper fix I'd need to see with Last Tab's 
developer.

Let me know if you want this quick fix.

Original comment by mlalevic@gmail.com on 30 Jun 2011 at 3:10

[GoogleCodeExporter]

Hi,

Thanks for the offer, but I don't need a quick fix.  

I've notified the Last Tab Close Button developer, he may respond here with 
more questions.  Or you could email him directly, his email is listed on 

https://addons.mozilla.org/en-US/firefox/addon/last-tab-close-button/

He has started to look into it, and may have some ideas.

Regards,

Peter 

Original comment by khteprs...@gmail.com on 30 Jun 2011 at 4:20

[GoogleCodeExporter]

Discuss your quick fix for Last Tab Close Button

Original comment by sacharin...@gmail.com on 30 Jun 2011 at 4:46

[GoogleCodeExporter]

Hi Sacharin, thanks for joining in.
This is what is happening: New Tab Jumpstart is intercepting about:blank and 
replacing it with chrome://jumpstart/content/tabView.xul, this means that when 
the last tab remains it cannot be closed because Last Tab Close Button is 
checking for about:blank.
The quick fix I had in mind - and only for Peter is to change code:
var emptyTab = gBrowser.contentDocument.location == "about:blank"; // Empty tab
to
var emptyTab = gBrowser.contentDocument.location == "about:blank" || 
gBrowser.contentDocument.location == "chrome://jumpstart/content/tabView.xul"; 
// Empty tab

However this is probably not the best solution. Ideally I would like to 
register "chrome://jumpstart/content/tabView.xul" with your extension so it is 
regarded as about:blank.

Something along lines: 
if(lasttabclosebutton){lasttabclosebutton.AddBlankPageUrl("chrome://jumpstart/co
ntent/tabView.xul");}

What do you think about that?

Original comment by mlalevic@gmail.com on 30 Jun 2011 at 5:16

[GoogleCodeExporter]

Hi Mihailo!

I test this - work incorrect. Previously loaded jumpstart, them close window.
In Speed ​​Dial this issue is resolved as not to load Speed​Dial page in 
the last tab.
Advanced -> Miscellaneous -> Load in last tab - set false.

Is it possible to implement a similar behavior of your extension?

Best regards,
Victor Sacharin

Original comment by sacharin...@gmail.com on 3 Jul 2011 at 4:10

[GoogleCodeExporter]

Hi Victor,
Good idea actually, will do something like that.

Cheers,
Mihailo

Original comment by mlalevic@gmail.com on 6 Jul 2011 at 4:15

[GoogleCodeExporter]

Hi, will a fix for this issue be included in the next release?  When might we 
see the next release?

Hope this isn't too much of an annoyance!

Peter

Original comment by khteprs...@gmail.com on 8 Aug 2011 at 9:28

[GoogleCodeExporter]

Hi Peter, sorry for the late reply I'm on holidays. This will go out with the 
next release. The next bigger release should be ready by the end of September, 
but I hope there will be some quicker interim release withing two weeks. I have 
to address some future Firefox 7 incompatibilities so I'll squeeze this fix in 
too.

Original comment by mlalevic@gmail.com on 13 Aug 2011 at 2:39

• Added labels: Milestone-0.5a5.5

[GoogleCodeExporter]

Original comment by mlalevic@gmail.com on 28 Aug 2011 at 9:29

• Changed state: Fixed

[GoogleCodeExporter]

Hi, any chance a new version will be released eventually?

thanks,

Peter

Original comment by khteprs...@gmail.com on 30 Mar 2012 at 9:48

[GoogleCodeExporter]

@khteprster
Unfortunately unlikely in next couple of months.

Original comment by mlalevic@gmail.com on 4 Apr 2012 at 8:33