mlflow / mlflow-go

Repository for the Go-based MLflow Tracking Server
Apache License 2.0
5 stars 4 forks source link

Populate override_test.* files with Python tests. #71

Closed dsuhinin closed 1 month ago

dsuhinin commented 1 month ago

@dsuhinin, could you please clarify why we need this? I feel like I'm missing the point. To an inexperienced eye, it seems like you're duplicating Python code. Would it not be more ideal to refactor upstream to address this?

Of course! We just skip some tests because of different problems we had. I've decided that better to do not make them just empty/skip but rather have actual test bit without the part of the code which fails on our end. Ideally of course this changes should be in MLFlow, but most of them related to our part like: