mlflow / mlflow-go

Repository for the Go-based MLflow Tracking Server
Apache License 2.0
5 stars 4 forks source link

Upgrade go version from 1.22 to 1.23 #72

Closed fabiovincenzi closed 3 weeks ago

fabiovincenzi commented 1 month ago

Fixes https://github.com/mlflow/mlflow-go/issues/65

nojaf commented 1 month ago

Please also update golangci-lint: https://github.com/golangci/golangci-lint/releases/tag/v1.61.0 and mockery: https://github.com/vektra/mockery/releases/tag/v2.46.3 Perhaps (https://pkg.go.dev/google.golang.org/protobuf/cmd/protoc-gen-go, do in separate commit, see what CI says, if negative don't go for it)

nojaf commented 1 month ago

@fabiovincenzi there were a couple of //nolint:ireturn comments that were removed. You need to restore these. The clue is that the linter should now not mark these as false positives anymore.