search

mlhartme / sushi

Scripting Library for Java
Apache License 2.0
7 stars 4 forks source link

NetRc refactor and rename #6

Closed mfriedenhagen closed 10 years ago

mfriedenhagen commented 10 years ago
mlhartme commented 10 years ago

I've integrated netrc support in SshNode - does it look reasonable for you now? I wonder if I can replaced the "passphrase" file by netrc, but a passphrase is not a password ...

I've also changed netrc loading in World - it's loaded when you use the create methods (with proper exceptions). This should simply tests for netrc loading.

I think about dumping the World() and World(boolean) constructors and move all this logic into World.create(), and create becomes the standard way to create a world. Looks cleaner too me. What do you thing about that?

mfriedenhagen commented 10 years ago

Concerning spaces: we could extend the .netrc format to say everthing after password will be read until EOF or EOL is reached, but I do not think other tools will recognize this.