search

mljs / regression-multivariate-linear

Multivariate linear regression
MIT License
33 stars 13 forks source link

Fix inheritance #13

Closed rainij closed 5 years ago

rainij commented 5 years ago

Remove dependency on package ml-regression-base.

In particular removed inheritance of MultivariateLinearRegression on BaseRegression since the latter is restricted to univariate regression.

codecov[bot] commented 5 years ago

Codecov Report

Merging #13 into master will decrease coverage by 0.17%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #13      +/-   ##
==========================================
- Coverage    87.5%   87.32%   -0.18%     
==========================================
  Files           3        3              
  Lines          72       71       -1     
  Branches       17       17              
==========================================
- Hits           63       62       -1     
  Misses          8        8              
  Partials        1        1
Impacted Files Coverage Δ
src/index.js 86.95% <ø> (-0.19%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b959b17...bc42723. Read the comment docs.

rainij commented 5 years ago

Is the thing with code coverage a serious issue? I am not familiar with codecov so I am not sure what to think about it.

targos commented 5 years ago

Coverage is not an issue. Thank you for the pull request!