mlocati / docker-php-extension-installer

Easily install PHP extensions in Docker containers
MIT License
4.34k stars 388 forks source link

Use multi-arch building to have arm64 and amd64 images on docker hub #1009

Closed baschny closed 1 week ago

baschny commented 1 week ago

In order to build a multi arch image (arm64 and amd64) on release on docker hub:

Tested on my own account: https://hub.docker.com/r/baschny/php-extension-installer/tags

Resolves #1005

mlocati commented 1 week ago

Why just linux/amd64 and linux/arm64?

I'd use all the platforms defined by the official PHP images...

For example, for the latest php:8.3 image I see these architectures at https://hub.docker.com/_/php/tags:

(It seems a bit strange to me that an image cannot be defined as "platform independent", but I guess we have to accept it)

baschny commented 1 week ago

Good idea - its so small anyway :) It works: https://hub.docker.com/r/baschny/php-extension-installer/tags, see a750748

mlocati commented 1 week ago

Thanks!

mlocati commented 1 week ago

PS: this required a minor fix - see https://github.com/mlocati/docker-php-extension-installer/commit/2654a6902afbf87d616a364cf7eb269360a75de9

mlocati commented 4 days ago

And there was a major issue: see #1016 (fixed by 2e59715b3cde9dfbe35be0cea8e509e2fcce5b13)