mlr-org / mlr3

mlr3: Machine Learning in R - next generation
https://mlr3.mlr-org.com
GNU Lesser General Public License v3.0
947 stars 85 forks source link

we really need to check code for metrics in terms of "sample_weights" and normalization. #1138

Open berndbischl opened 2 months ago

berndbischl commented 2 months ago

should be carefully read, but also unit tested in terms of behavior. maybe test sse1(w1) + sse2(w2) = sse2(w)

berndbischl commented 2 months ago

also not sure why we use "sample_weights" and not simply weights....

tdhock commented 2 weeks ago

weights (without sample) is frequently used in the neural network literature, to refer to the learned parameters