search

mlr-org / mlrMBO

Toolbox for Bayesian Optimization and Model-Based Optimization in R
https://mlrmbo.mlr-org.com
Other
187 stars 47 forks source link

fixes from CRAN #520

Open jakob-r opened 2 years ago

jakob-r commented 2 years ago

Just transferring ripleys fixes/changes logged here

CRAN package akima has a restricted-use licence. Package interp has a FOSS licence and provides a drop-in replacement for akima's functions

bicubic bicubic.grid bilinear bilinear.grid interp interp2xyz interpp

So please investigate if akima can be replaced by interp, and either submit an updated version or let CRAN and Albrecht Gebhardt know what the issues were, before 2022-07-04 to safely retain your package on CRAN.

Packages DiceEval mlrMBO seem not to use akima at all.

Packages bmstdr dynaTree erpR flipr laGP plgp vegdata do not seem to use akima conditionally, which is expected for all suggested packages and especially for those which are not universally available.

Also not sure why akima was needed.

pat-s commented 2 years ago

Ahh, that's where the {interp} issue in the tests comes from. Let's see if the tests are now happy after adding {interp} so suggests and maybe we can directly remove {akima}.

pat-s commented 2 years ago

@jakob-r Am I right to assume that these changes were already commited to mlrMBO on CRAN?

jakob-r commented 2 years ago

Yes. As you can see in the linked github cran mirror.