This PR extends the createGroup script step so that an initial set of members can be specified. These members are added using the Add/Welcome flow, in a single initial commit. This makes it easier to set up an initial group, so that we no longer need the hack of using externalJoin to build up the initial group. As a result, we get much richer passive client tests from the active-to-passive transformation, since Welcomed joiners can participate in active-to-passive tests, but external joiners cannot.
Summary of changes:
Updated ActionCreateGroup to take a members array and make the appropriate sequence of RPCs
Updated the configs to make use of the extended createGroup (note that this also required adjusting the cross-references in the scripts)
Ran active_to_passive.sh to convert the updated scripts to passive client tests
Added a -quiet option to suppress JSON output
I have verified that the updated active test scripts and the resulting passive tests succeed with MLSpp.
This PR extends the
createGroup
script step so that an initial set of members can be specified. These members are added using the Add/Welcome flow, in a single initial commit. This makes it easier to set up an initial group, so that we no longer need the hack of usingexternalJoin
to build up the initial group. As a result, we get much richer passive client tests from the active-to-passive transformation, since Welcomed joiners can participate in active-to-passive tests, but external joiners cannot.Summary of changes:
ActionCreateGroup
to take amembers
array and make the appropriate sequence of RPCsconfigs
to make use of the extendedcreateGroup
(note that this also required adjusting the cross-references in the scripts)active_to_passive.sh
to convert the updated scripts to passive client tests-quiet
option to suppress JSON outputI have verified that the updated active test scripts and the resulting passive tests succeed with MLSpp.