mlswg / mls-implementations

Coordination of implementation and interop specific details
110 stars 14 forks source link

Extend 'createGroup' to also welcome members #162

Closed bifurcation closed 1 year ago

bifurcation commented 1 year ago

This PR extends the createGroup script step so that an initial set of members can be specified. These members are added using the Add/Welcome flow, in a single initial commit. This makes it easier to set up an initial group, so that we no longer need the hack of using externalJoin to build up the initial group. As a result, we get much richer passive client tests from the active-to-passive transformation, since Welcomed joiners can participate in active-to-passive tests, but external joiners cannot.

Summary of changes:

I have verified that the updated active test scripts and the resulting passive tests succeed with MLSpp.