Closed bifurcation closed 1 year ago
@franziskuskiefer - Except it is used now! Because you need to know what hash to use for the tree hashes. Might want to check that OpenMLS isn't pretending to know the ciphersuite for a tree when it doesn't ;)
Might want to check that OpenMLS isn't pretending to know the ciphersuite for a tree when it doesn't ;)
The cipher suite was simply hard-coded in the test. OpenMLS doesn't make any assumptions.
@franziskuskiefer - Except it is used now! Because you need to know what hash to use for the tree hashes. Might want to check that OpenMLS isn't pretending to know the ciphersuite for a tree when it doesn't ;)
That's what I meant with adding tests for other ciphersuites. It was hard coded in OpenMLS before but all tvs still use the same ciphersuite, such that it worked even when ignoring the ciphersuite in the tv.
Adds the
cipher_suite
field to the tree operations test vector.MLSpp now passes on this test vector. @franziskuskiefer not sure how you were able to pass on the one in #168 without this field. Could you please re-verify?