search

mmende / homebridge-samsungtv-control2

homebridge-samsungtv-control2
MIT License
71 stars 17 forks source link

Update `parseSerialNumber` function #84

Closed Philanatidae closed 2 years ago

Philanatidae commented 2 years ago

parseSerialNumber is outdated (see #40). I updated the years to include 2020. I also added a note in the README to reflect the fact that model numbers through 2020 can be parsed. If a newer model is produced by Samsung, parseSerialNumber will have to be updated again.

Reference from Samsung: https://www.samsung.com/us/support/answer/ANS00087664/

Fixes #70, #48, #40.

mmende commented 2 years ago

Thanks for the contribution... I'll try to look through it and merge it this week

ghost commented 2 years ago

Please merge this

taylorsatula commented 2 years ago

^^ bump ^^

mmende commented 2 years ago

Merged and published under v2.1.0

taylorsatula commented 2 years ago

@Philanatidae @mmende Thanks for the commit and merge! This fixed my issue where HomeBridge would not add a TV to my network even when the UID, MAC, and IP were correct. It would say "XYZ unknown. Skipping now."

Samsung UN55TU8000FXZA

I still haven't figured out how to add volume control and stuff to the remote. Right now it has two "source" options and an unresponsive power button but I'll figure those parts out with time. At least it connects now.

Thanks!