mmistakes / jekyll-theme-skinny-bones

A Jekyll starter with a variety of flexible layouts and components.
https://mmistakes.github.io/jekyll-theme-skinny-bones
MIT License
802 stars 909 forks source link

Disqus has changed their code slightly #47

Open dixonge opened 8 years ago

dixonge commented 8 years ago

FYI, the new Disqus 'Engage' code has 1 requisite parameter and 2 optional ones. If you update the script in comments.html, you might need to change the variables involved. I just replaced it all with code as provided by disqus and wrapped it in {% if page.comments %} liquid and it's working fine on two different sites.

sitename.disqus.com is something you can get from your Disqus settings page_url and page_identifier I'm not sure about - perhaps something auto-generated by liquid?

<div id="disqus_thread"></div>
<script>
    /**
     *  RECOMMENDED CONFIGURATION VARIABLES: EDIT AND UNCOMMENT THE SECTION BELOW TO INSERT DYNAMIC VALUES FROM YOUR PLATFORM OR CMS.
     *  LEARN WHY DEFINING THESE VARIABLES IS IMPORTANT: https://disqus.com/admin/universalcode/#configuration-variables
     */
    /*
    var disqus_config = function () {
        this.page.url = PAGE_URL;  // Replace PAGE_URL with your page's canonical URL variable
        this.page.identifier = PAGE_IDENTIFIER; // Replace PAGE_IDENTIFIER with your page's unique identifier variable
    };
    */
    (function() {  // DON'T EDIT BELOW THIS LINE
        var d = document, s = d.createElement('script');

        s.src = '//SITENAMEGOESHERE.disqus.com/embed.js';

        s.setAttribute('data-timestamp', +new Date());
        (d.head || d.body).appendChild(s);
    })();
</script>
<noscript>Please enable JavaScript to view the <a href="https://disqus.com/?ref_noscript" rel="nofollow">comments powered by Disqus.</a></noscript>```
mmistakes commented 8 years ago

Is it documented anywhere about the embed code change? Disqus has had the PAGE_URL and PAGE_IDENTIFIER variables for some time now. Unless something has changed they're optional and just help better tie comments to a post in the case you move to a different domain or the URLs change.

mmistakes commented 8 years ago

Nevermind. Found it.

dixonge commented 8 years ago

ok, cool