mmistakes / minimal-mistakes

:triangular_ruler: Jekyll theme for building a personal site, blog, project documentation, or portfolio.
https://mmistakes.github.io/minimal-mistakes/
MIT License
12.47k stars 25.71k forks source link

Adjust colour for border-left when using {: .notice } classes in blockquotes #3068

Closed Andre601 closed 2 years ago

Andre601 commented 3 years ago

Environment

*Please note that I don't use ruby nor jekyll locally and that everything is done through GitHub pages. The version listed here is from the Dependency versions page for GitHub Pages.

Expected behavior

When using the {: .notice } option together with a blockquote (See reproduction steps) should the line used on the left side mimic the color used for the notice-type applied.

Steps to reproduce the behavior

Write a blockquote with a notice similar to this setup:

> This is a quote block.
> It is used to wrap multiple lines, including blank ones, into a `<p>` or something similar to then apply the `{: .notice--warning }` class.
>
> I use this since it's a bit easier than using a `<div>` solution.
{: .notice--warning }

Once rendered, you will notice that the blockquote will have a bright blue line on the left, while the body is an orange from the notice--warning class.

This feels out of place, but makes sense since the notice classes don't seem to override the border when they are used in combination with a blockquote, which is possible.

Other

It's a minor visual issue, so I understand if changing this wouldn't take priority at all or doesn't even get worked on at all, but considering that using a block quote for larger areas together with the notice classes allows more simple formatting than using div classes (That either requires usage of HTML OR the {% capture %} option) would it be a shame if this wouldn't be corrected.

github-actions[bot] commented 3 years ago

This issue has been automatically marked as stale because it has not had recent activity.

If this is a bug and you can still reproduce this error on the master branch, please reply with any additional information you have about it in order to keep the issue open.

If this is a feature request, please add as an Idea under discussions and elaborate on why it is core to this project and why you feel more than 80% of users would find it beneficial.

This issue will automatically be closed in 7 days if no further activity occurs. Thank you for all your contributions.

iBug commented 3 years ago

@mmistakes Got time to take a look at this one and the PR? Should be easy and harmless.