Add Python 3 compatibility

mmolero / pypoisson

Poisson Surface Reconstruction Python Binding

MIT License

243 stars 30 forks source link

Add Python 3 compatibility #6

Closed HendrikF closed 5 years ago

HendrikF commented 5 years ago

strs get encoded to bytes
"strings" get replaced with b"bytes", Python 2 just ignores the b
classic division changed to floor division, because we don't want floats there

Behaviour should not have changed. I am still able to reconstruct clouds.

MrSaints commented 5 years ago

I've tested, and this fixes:

Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "src/pypoisson.pyx", line 100, in pypoisson.poisson_reconstruction
    return _poisson_reconstruction(np.ascontiguousarray(np.float64(points)), np.ascontiguousarray(np.float64(normals)),
  File "src/pypoisson.pyx", line 112, in pypoisson._poisson_reconstruction
    string arg_depth = str(depth)
  File "stringsource", line 15, in string.from_py.__pyx_convert_string_from_py_std__in_string
TypeError: expected bytes, str found