search

mmorise / World

A high-quality speech analysis, manipulation and synthesis system
http://www.kisc.meiji.ac.jp/~mmorise/world/english
Other
1.18k stars 253 forks source link

Add controllable harvest parameters #102

Closed stakemura closed 4 years ago

stakemura commented 4 years ago

The computation time of harvest is strongly depended on channels_in_octave. This patch made channels_in_octave controllable from outside.

mmorise commented 4 years ago

Thank you for your request.

As you pointed out, it is possible to change so that the parameter channels_in_octave is controllable. However, I don't recommend this modification because the estimation performance depends on not only the channels_in_octave but also other parameters. In the implementation, we tuned all parameters to achieve better performance. When you modified only the channels_in_octave, the estimation performance would get worse performance.

stakemura commented 4 years ago

I appreciate your helpful comment. As the following commit intended, I'm now working on it to improve the estimation performance by increasing controllable parameters. https://github.com/stakemura/World/commit/8a561d9675d06651c5bbf4d0e0c671feb8b1c76b

Would it be possible to show us the other parameters that we should tune? I would like to send more PR.

stakemura commented 4 years ago

We confirmed that close this PR and consider an alternative plan through direct conversation. Thanks!