Open jschepers opened 3 weeks ago
Hello! 👋 Thanks for opening your first pull request here! ❤️ We will try to get back to you soon. 🚴🏽♂️
thanks for the quick feedback! We will still need some time to work on this, too many parallel things going on.
Because we mainly develop in Julia, not everything is clear to us. I will ask some clarifications on the workflow.
Just foreshadowing two PRs we want to submit: 1) eyelink synchronisation: we understand it is a bit specific, but it is implemented in MNE, so we added a new step to support it (80% ready for PR) 2) zapline: this will be added to the filter thing as a quasi-replacement for 50/60Hz notch filtering, based on meegkit (only just started with the planning of that one).
Changes
ica_use_ecg_detection
andica_use_eog_detection
to control whether MNE eog/ecg detection should be used on the ICsicalabel_include
) which labels/ICs to include. Default is["brain","other"]
.Before merging …
docs/source/dev.md.inc
)