search

mne-tools / mne-features

MNE-Features software for extracting features from multivariate time series
https://mne-tools.github.io/mne-features/
BSD 3-Clause "New" or "Revised" License
142 stars 32 forks source link

Compatibility with scikit-learn v0.21 #49

Closed jbschiratti closed 5 years ago

jbschiratti commented 5 years ago

This solves #48.

agramfort commented 5 years ago

@jbschiratti can you remove testing on 2.7 by removing this line:

https://github.com/mne-tools/mne-features/blob/master/.travis.yml#L4

it should fix travis

codecov[bot] commented 5 years ago

Codecov Report

Merging #49 into master will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #49   +/-   ##
=======================================
  Coverage   93.69%   93.69%           
=======================================
  Files          10       10           
  Lines        1221     1221           
=======================================
  Hits         1144     1144           
  Misses         77       77
Impacted Files Coverage Δ
mne_features/mock_numba.py 100% <100%> (ø) :arrow_up:
mne_features/feature_extraction.py 95.27% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c41ebc4...25472f8. Read the comment docs.

agramfort commented 5 years ago

Thx @jbschiratti