search

mnin / coinbase-moneymoney

Fetches balances from Coinbase API and returns them as securities
MIT License
24 stars 4 forks source link

Refresh results incomplete #8

Closed MattesGroeger closed 3 years ago

MattesGroeger commented 3 years ago

I noticed that since ~3rd of June 2021 the api response of the extension is incomplete, meaning not all assets supported by coinbase are included anymore (certainly, none of my holdings are part of the response anymore). I was not yet able to debug the code myself but my assumption ist that coinbase increased the amount of assets to an extend that exceeds the maximum amount of results per page and therefore does not return all assets (only 25 assets are shown). As far as I could see there is no pagination support in the extension. But maybe I'm wrong and there is another reason for the incomplete response. Would be great to get this fixed soon as my coinbase account shows up with an empty balance since then.

MattesGroeger commented 3 years ago

Update: when limiting the "accounts" for the api key to the ones I'm using (less than 25) it starts working again. I set it before to "all accounts" as it suggested in the documentation. So seems to be really related to pagination.

mnin commented 3 years ago

@MattesGroeger can you share a screenshot with the account list to the API key stored in MoneyMoney?

mnin commented 3 years ago

Like this one:

image

mnin commented 3 years ago

@MattesGroeger otherwise, you can contact me on Twitter: @mnin if you need support

MattesGroeger commented 3 years ago

Hi @mnin, thx for trying to help. This (your screenshot) is how it looked like for me when it was broken. I fixed it by reducing the amount of accounts to the set I only need. So I'm good now but the extension is still broken if people follow the the instructions (screenshot): https://github.com/mnin/coinbase-moneymoney#api-key

mnin commented 3 years ago

@MattesGroeger what exactly is broken? You haven't provided any information for your problem, but tell me the extension is broken in general? Not even a version number you are currently using?

Anyway, for me the latest version (https://github.com/mnin/coinbase-moneymoney/releases/tag/v1.8) is running, even if I use it in a new installation of MoneyMoney. I get all the currencies, even the new ones (GTC, MLN and AMP) that were just added to Coinbase. Got 69 items right now.

I have spent a lot of time keeping this extension in working condition and am happy to help. But claiming something is broken here without any information and apparently having benefited from this project before without sharing anything is probably not the point of open source software.

mnin commented 3 years ago

@MattesGroeger probably forgot to update the version.

MattesGroeger commented 3 years ago

Hi @mnin, thx for your response and looking into the issue. After re-reading my messages I have to agree that I was not very polite and it could come across quite demanding from my side. Thx for providing this feedback.

I appreciate the work you have put into the extension and also that you offered your support.

mnin commented 3 years ago

Thanks @MattesGroeger, could an update of the extension solve your problem?