mnin / coinbase-moneymoney

Fetches balances from Coinbase API and returns them as securities
MIT License
24 stars 4 forks source link

only show coins with balances #9

Closed udochrist closed 3 years ago

udochrist commented 3 years ago

as there are a lot of coins on coinbase and the list starts to flood the display only show the non-fiat with a balance

mnin commented 3 years ago

Hey @udochrist, thanks for your pull request.

But don't you want to keep the history if you once had a currency in the portfolio and sold it in the meantime?

udochrist commented 3 years ago

fair point. However I'm rather interested in a comprehensive overview of what I have now instead of a list of 60+ 0-Zero positions out of which 1 might have been used historically.

I find the API of money money lacking at that point. They should either present the current balances when retrieving the new balances instead of the date param or keep track of a historic journal out the the methods return value.

other options: the change I made could also be triggered only in case a special parameter is set (i.e. 2nd loginname with special value).

I don't mind if you reject the PR. it was created in minutes. I've forked your repo and am using the change at my end.

mnin commented 3 years ago

Hey @udochrist, thanks for your patience. I have tried your PR and discussed with a few people what their opinion is on this.

I would now want to merge your PR, build a new version with the number 2.0 and write in the README above that from version 2.0 all coins with the value 0 also disappear from the individual history.

udochrist commented 3 years ago

Hi Martin,

You are very welcome to do so!

Cheers Udo

On 30. Aug 2021, at 15:16, Martin Wilhelmi @.***> wrote:

 Hey @udochrist, thanks for your patience. I have tried your PR and discussed with a few people what their opinion is on this.

I would now want to merge your PR, build a new version with the number 2.0 and write in the README above that from version 2.0 all coins with the value 0 also disappear from the individual history.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe. Triage notifications on the go with GitHub Mobile for iOS or Android.

mnin commented 3 years ago

@udochrist signed version is also up to date right now