V1.0 - GOLD-883: iOS Scroll Fix V2

mobify / mobifyjs

Mobify.js was a JavaScript framework for optimizing sites for mobile. It is no longer actively maintained.

https://www.mobify.com/

Other

643 stars 83 forks source link

V1.0 - GOLD-883: iOS Scroll Fix V2 #291

Closed MikeKlemarewski closed 10 years ago

MikeKlemarewski commented 10 years ago

Merge checklist:

[x] Removes the old iOS 8.0 patch
[x] Adds the new iOS 8.0 patch
[x] Uses the correct iOS 8.0 regex (that works with the simulator)
[x] Calls the new patch
[x] Has a test for the new patch
[x] Has a test for the iOS 8.0 form sibblings bug

Adds patch to fix iOS8 scroll bug

Status: Opened for visibility

Reviewers: @jvaill @jansepar

jvaill commented 10 years ago

So I was trying to figure out why this diff was off.. and then I noticed that the merge pull request button is disabled. @MikeKlemarewski can you merge 1.0 into this?

MikeKlemarewski commented 10 years ago

Tested on android, iphone 5 and iphone 6 running 8.0.2. I deem this working!

jansepar commented 10 years ago

Just realized CST didn't test 1.0 projects. Let's quickly test lulu before merging this puppy in!

jansepar commented 10 years ago

Tested lulu - looks good! :+1: nice checklist btw :)