TransitionEnd Event never actually fires on Galaxy S3 Phone

[tedtate]

Status: For discussion Reviewers: @scalvert @donnielrt @kpeatt @Bielousov

Changes

• Make 'WebkitTransition' the default transition event as it seems to be the most compatible

  Notes

• So on the Galaxy S3 browser it seems like we detect that the 'transition' event is supported but for some reason it doesn't actually ever fire. This causes the windows height to be locked after pikabu is closed blocking users from scrolling.

  Todo

• [ ] Verify that this is the best way to fix the issue.
• [ ] What events do we actually see fired on the Galaxy S3? On other 4.3 AOSP browsers?
• [ ] Create minimal test case for this issue.
• [ ] Verify this fix against
  • [ ] iOS 8
  • [ ] iOS 7
  • [ ] Android 4.3
  • [ ] Android 4.4
  • [ ] Chrome
  • [ ] Firefox

[donnielrt]

Seems like the alternative would be to add a special check for S3 (shudder), so this definitely makes more sense.

[donnielrt]

I'm assuming we've managed to replicate this with a minimal test case?

[tedtate]

@donnielrt Yah, I think we need to do some investigation to make sure that this is a general issue not project specific. That said, I found this branch that Anton made a few months ago and the fix was exactly what I needed.

It also may be the same issue that was occurring here: https://github.com/mobify/pikabu/issues/43

[donnielrt]

Hey, we’re looking to prune older unattended PRs. If this PR is still relevant and you would like to see it merged in, please reopen the PR and we’ll add it to our backlog! Thanks!