mobify / pinny

A mobile-first content fly-in UI plugin
MIT License
23 stars 4 forks source link

Fix input disabling #58

Closed scalvert closed 9 years ago

scalvert commented 9 years ago

Fixes the input disabling where using data caused it to not work!

Status: Open for visibility

Reviewers: @tedtate @kpeatt @Helen-Mobify

Changes

scalvert commented 9 years ago

@Helen-Mobify

kpeatt commented 9 years ago

We'll need to make this change to Pikabu as well.

wizardlyhel commented 9 years ago

The document.activeElement can be undefined if there is an iframe in the pinny.

scalvert commented 9 years ago

OK I've done some rework with things like method names and also order of operations. I needed to tweak the order of operations of input disabling to ensure it was running at the correct time.

wizardlyhel commented 9 years ago

:+1: looks good @scalvert