Closed scalvert closed 9 years ago
@Helen-Mobify
We'll need to make this change to Pikabu as well.
The document.activeElement can be undefined if there is an iframe in the pinny.
OK I've done some rework with things like method names and also order of operations. I needed to tweak the order of operations of input disabling to ensure it was running at the correct time.
:+1: looks good @scalvert
Fixes the input disabling where using
data
caused it to not work!Status: Open for visibility
Reviewers: @tedtate @kpeatt @Helen-Mobify
Changes
How to test-drive this PR
grunt test
grunt serve
and ensure that pinny is correctly enabling/disabling inputs on open/closeTODO