mobilizingcs / MobilizePrime

Simple wrapper functions for high school curriculum
http://www.exploringcs.org/curriculum
5 stars 2 forks source link

Top count for wordclouds and wordbars #9

Closed AmeliaMN closed 10 years ago

AmeliaMN commented 11 years ago

Make it possible to specify top.count=100 and see only the 100 most common words. in MakeWordCloud

jimmylovestea commented 10 years ago

Need to decide how to best specify top 1 word and top 100% of words. Ask for clarification as to whether decimal numbers (10.5 for instance) should be allowed to be specified.

AmeliaMN commented 10 years ago

Yeah, this is another one that needs a little thought. I don't think we need to support decimals, but I assume it wouldn't be that complicated to support. E.g. top.percent=10.5

hongsudt commented 10 years ago

Currently the "top" parameter is overloaded with both the top rank and top percentage. If the specified value is >=1, then it implies rank and if the value <1, then it implies percentage.. The issues are:

These are pedagogy questions.. I would go for splitting the param and support the decimal rank.

On Wed, Dec 18, 2013 at 11:12 AM, AmeliaMN notifications@github.com wrote:

Yeah, this is another one that needs a little thought. I don't think we need to support decimals, but I assume it wouldn't be that complicated to support. E.g. top.percent=10.5

— Reply to this email directly or view it on GitHubhttps://github.com/AmeliaMN/MobilizeSimple/issues/9#issuecomment-30870910 .

jimmylovestea commented 10 years ago

Add 2 arguments to the functions:

In the case for 'count' the top argument would be the top m words. In the case for 'percernt' the top arguments would be the top m percent.

jimmylovestea commented 10 years ago

Update help & wiki.