search

moby / libnetwork

networking for containers
Apache License 2.0
2.16k stars 881 forks source link

Revert: Added API to set ephemeral port allocator range #2668

Closed sbuckfelder closed 2 years ago

sbuckfelder commented 2 years ago

Signed-off-by: Scott Buckfelder buckscot@amazon.com

Warning libnetwork was moved to https://github.com/moby/moby/tree/master/libnetwork

libnetwork has been merged to the main repo of Moby since Docker 22.06.

The old libnetwork repo (https://github.com/moby/libnetwork) now only accepts PR for Docker 20.10, and will be archived after the EOL of Docker 20.10.

Reference Issue : https://github.com/moby/moby/issues/44423

This PR backports the current behavior in moby/moby to 20.10. The PR for master is #43066

Testing

Ran make and make unit-tests. The unit tests had one failure that also exists in the master branch

--- FAIL: TestDNSOptions (0.16s)
    service_common_test.go:65: assertion failed: expected [timeout:2 attempts:5 ndots:0] (length 3) to have length 1
    service_common_test.go:66: assertion failed: ndots:0 (string) != timeout:2 (dnsOptionsList[0] string)
sbuckfelder commented 2 years ago

Instrumental in the initial PR: @akerouanton @thaJeztah