search

mockito / shipkit

Toolkit for shipping it used by Mockito library
http://shipkit.org
MIT License
158 stars 35 forks source link

BintrayDefaultArtifactUrlResolver does not URL encode slashes in file_path #851

Closed cgtz closed 4 years ago

cgtz commented 4 years ago

There seem to have been some recent changes to the download URLs that bintray accepts. For example, https://bintray.com/linkedin/maven/download_file?file_path=com/github/ambry/ambry-router/0.3.70/ambry-router-0.3.70-sources.jar now gets a 404.

Now, the URL only resolves if the file_path query param is properly url encoded: https://bintray.com/linkedin/maven/download_file?file_path=com%2Fgithub%2Fambry%2Fambry-router%2F0.3.70%2Fambry-router-0.3.70-sources.jar

Could we change BintrayDefaultArtifactUrlResolver::getDefaultUrl to URL encode the path?

cgtz commented 4 years ago

Closing issue, sorry this might not have been the actual issue here