search

mockito / shipkit

Toolkit for shipping it used by Mockito library
http://shipkit.org
MIT License
158 stars 35 forks source link

Fixed GitHub authorization #871

Closed shestee closed 4 years ago

shestee commented 4 years ago

GitHub will no longer support authentication through query parameters (reported in issue #864; more info: https://developer.github.com/changes/2019-11-05-deprecated-passwords-and-authorizations-api/#authenticating-using-query-parameters, https://developer.github.com/changes/2020-02-10-deprecating-auth-through-query-param/). To deal with this issue there was a need to move authentication to the connection header. It was done in GitHubListFetcher and GitHubObjectFetcher classes. Followed by this refactor there was also a necessity to refactor GitHubContributorsFetcher, RecentContributorsFetcher and GitHubTicketFetcher classes.

mockitoguy commented 4 years ago

I'm going to merge it because I cannot reproduce the failure locally so I think it's a red herring. The change is useful and avoid deprecation of GitHub API.