mod-audio / mod-sdk

SDK to implement the MOD gui interface
GNU General Public License v3.0
34 stars 16 forks source link

lilv.py runtime error #12

Open jpcima opened 5 years ago

jpcima commented 5 years ago

Hi, launching mod-sdk with lilv.py present produces this runtime error. I delete lilv.py from the system as a remedy, losing the plugin checking ability.

AttributeError: 'Node' object has no attribute 'as_string'

It happens with lilv 0.24.4. The same with a git build 0.24.5.r1226.01426de.

The objects Node don't appear to have as_string, but they have __str__.

falkTX commented 5 years ago

This is expected, lilv has changed drastically (from swig to ctypes) and the code was made with the old version in mind. Take a look at https://github.com/moddevices/lilvlib for a way to get a static build of python3-lilv compatible with mod-sdk

Note that this python lilv is an optional dependency. There should be a way to detect if the system provides a compatible one or not, and then disable it fully if not.

We do not have a big reason to update to latest lilv changes in mod-sdk right now, as the setup we have works well for us. There is work to do in order to update and follow upstream, and also risk of regressions.

jpcima commented 5 years ago

Got it, I will then try to get it working using this version of lilvlib.

There should be a way to detect if the system provides a compatible one or not, and then disable it fully if not.

Then I will leave it open until this item is resolved.