search

modAL-python / modAL

A modular active learning framework for Python
https://modAL-python.github.io/
MIT License
2.24k stars 324 forks source link

Dev #70

Closed somang closed 4 years ago

somang commented 4 years ago

Minor edition to models.py as explained in the Issues Ticket

cosmic-cortex commented 4 years ago

Thanks! I'll review the PR over the weekend and get back to you!

cosmic-cortex commented 4 years ago

You have selected the wrong branches for the PR. You need to open the PR from your fork, making sure that you select the correct branch and also that the target is the dev branch of the parent repository.

cosmic-cortex commented 4 years ago

Also, I have seen in your fork that you moved the learners.py file to the modAL folder. (https://github.com/somang/modAL/commit/cac0cd7922748fbf979d627845b2caf17e60169a) This is not good for two reasons. First, the package itself won't work if you move this file without any additional changes. Second, I have no way to inspect the differences you introduced in this commit.

Can you make another fork, make a feature branch from dev, add your commit without moving any files and open the PR again? You can find a more detailed guide on how to contribute here: https://github.com/modAL-python/modAL/blob/master/CONTRIBUTING.md

somang commented 4 years ago

Oops, My apologies, I'll make the new PR soon. Sorry for my mistakes.

codecov-commenter commented 4 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@b301979). Click here to learn what that means. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #70   +/-   ##
=========================================
  Coverage          ?   97.19%           
=========================================
  Files             ?       31           
  Lines             ?     1641           
  Branches          ?        0           
=========================================
  Hits              ?     1595           
  Misses            ?       46           
  Partials          ?        0
Impacted Files Coverage Δ
modAL/models/learners.py 92.70% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b301979...f614e27. Read the comment docs.