model-checking / cbmc-viewer

CBMC Viewer scans the output of CBMC and produces a browsable summary of its findings, making it easy to root cause the issues it finds.
https://model-checking.github.io/cbmc-viewer/
Apache License 2.0
32 stars 11 forks source link

Repair xml parsing #96

Closed markrtuttle closed 2 years ago

markrtuttle commented 2 years ago

This pull request reverts to loading xml file directly from the file instead of reading the file into a string and patching the string before parsing it. The patch appears no longer to be needed since cbmc appears no longer to insert illegal characters into its xml output.

This pull request also reverts to raising an exception when viewer can't load an xml or json file.

This pull request also cleans up some top-level Makefile targets.

This pull request should be read commit-by-commit, as the commits themselves are small and the commit messages explain what is going on.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.