search

modelica-tools / csv-compare

Tool to compare curves from one csv files with curves from other csv files using an adjustable tolerance
https://www.modelica.org
BSD 3-Clause "New" or "Revised" License
25 stars 15 forks source link

Do not use the legacy TubeSize #70

Closed beutlich closed 1 week ago

beutlich commented 2 weeks ago

FYI @casella

casella commented 1 week ago

Once this is done, should we go for a new release? Should it be 2.1.0 or 2.0.5? I guess what we made is more than a patch.

uschna commented 1 week ago

Dear @beutlich, I have some problems: In https://github.com/modelica-tools/csv-compare/blob/master/Modelica_ResultCompare/CsvFile.cs I found at row 321: size = new TubeSize(reference, defaultNominalValue, useLegacyBaseAndRatio); not size = new TubeSize(reference, true); at row 316 I see, this come from https://github.com/modelica-tools/csv-compare/pull/67/files I do not know, what the parameters mean. If I understand https://github.com/modelica-tools/csv-compare/pull/67 correctly, it set some parameters of the curve compare. I don't know, what the best values are.