search

modelica / ModelicaStandardLibrary

Free (standard conforming) library to model mechanical (1D/3D), electrical (analog, digital, machines), magnetic, thermal, fluid, control systems and hierarchical state machines. Also numerical functions and functions for strings, files and streams are included.
https://doc.modelica.org
BSD 3-Clause "New" or "Revised" License
471 stars 168 forks source link

redundant variable definition in the sub package of Modelica.Fluid.Pipes.BaseClasses.WallFriction #3714

Open Satinelamp opened 3 years ago

Satinelamp commented 3 years ago

The purpose of Modelica.Fluid.Pipes.BaseClasses.WallFriction subpackage is to calculate the mass flow from pressure loss, or inversely. There are some redundant variables that aren't been used after defined.
It should be cleaner and easier to understand the code without them.

1 2 23

beutlich commented 3 years ago

@Satinelamp Why was it closed w/o comment? Your observation as reported is right.