modestimpala / OdinOnDemand

A mediaplayer mod for Valheim using SoundcloudExplode and YoutubeExplode
https://valheim.thunderstore.io/package/ValMedia/OdinOnDemand/
GNU Affero General Public License v3.0
1 stars 0 forks source link

Issue - Boombox does not update when switching to unlicensed song #7

Closed wd40pyro closed 1 year ago

wd40pyro commented 1 year ago

Issue: Songs do not update to correct the new song state if the follow up song is 'unlicensed' or not allowed to be played. Severity: Low Impact: Player confusion if there is issue when updating from song #1 to song #2. Likelihood: High Reproducibility: 100%

Observed Behavior - Steps to reproduce:

1) Set a song that allows to be played in like - https://soundcloud.com/foofighters/everlong?utm_source=clipboard&utm_medium=text&utm_campaign=social_sharing 2) Stop and / or set to a new song (that is unlicensed) like - https://soundcloud.com/nirvana/smells-like-teen-spirit-1?utm_source=clipboard&utm_medium=text&utm_campaign=social_sharing 3) Boombox will play Foo Fighters from step 1 (instead of not playing song 2).

Expectation: If a user hits 'set', it should auto-restart to whatever URL is present (even if the song is unlicensed it should probably do nothing than play the last played song.

Thanks for your review!