search

modflowpy / flopy

A Python package to create, run, and post-process MODFLOW-based models.
https://flopy.readthedocs.io
Other
506 stars 306 forks source link

test: replace test_mf6_examples.py with CI test job #2239

Closed wpbonelli closed 2 months ago

wpbonelli commented 2 months ago

Remove autotest/regression/test_mf6_examples.py and the associated parametrization in autotest/regression/conftest.py. I wrote these shortly after joining the team. Eventually they evolved into modflow-devtools fixtures to feed MF6 example models to test functions. It is cleaner to just check out the examples repo and run its own suite against the flopy or mf6 under test, though. This PR adds a job for this to mf6.yml. I plan to retire the fixtures soon; a models API as proposed for a future flopy would supersede them anyway.

This PR also moves regression testing to commit.yml and removes regression.yml. Regression tests were failing before this because the parametrization did not run GWF and GWE models in the proper order.

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 73.9%. Comparing base (1e44b3f) to head (67d4220).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #2239 +/- ## ========================================= + Coverage 70.4% 73.9% +3.5% ========================================= Files 294 294 Lines 59034 59032 -2 ========================================= + Hits 41586 43677 +2091 + Misses 17448 15355 -2093 ``` [see 56 files with indirect coverage changes](https://app.codecov.io/gh/modflowpy/flopy/pull/2239/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=modflowpy)