search

modflowpy / flopy

A Python package to create, run, and post-process MODFLOW-based models.
https://flopy.readthedocs.io
Other
506 stars 306 forks source link

fix(PlotMapView): default to all layers in plot_pathline() #2242

Closed wpbonelli closed 2 months ago

wpbonelli commented 2 months ago

Defaulting to layer 0 for arrays where each cell is assigned a color is sensible but for pathlines it seems more natural to include all layers for complete pathlines. This might (pragmatically) be seen as a bugfix rather than a breaking change?

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 67.8%. Comparing base (e48198c) to head (49da98f).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #2242 +/- ## ========================================= - Coverage 73.9% 67.8% -6.2% ========================================= Files 294 294 Lines 58886 58868 -18 ========================================= - Hits 43575 39929 -3646 - Misses 15311 18939 +3628 ``` | [Files](https://app.codecov.io/gh/modflowpy/flopy/pull/2242?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=modflowpy) | Coverage Δ | | |---|---|---| | [flopy/plot/map.py](https://app.codecov.io/gh/modflowpy/flopy/pull/2242?src=pr&el=tree&filepath=flopy%2Fplot%2Fmap.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=modflowpy#diff-ZmxvcHkvcGxvdC9tYXAucHk=) | `81.2% <100.0%> (-2.3%)` | :arrow_down: | ... and [196 files with indirect coverage changes](https://app.codecov.io/gh/modflowpy/flopy/pull/2242/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=modflowpy)