modmore / VersionX

Resource & Element Versioning Extra for MODX Revolution (supports 2.2 and up). Extends the core in a future-proof manner to keep copies of every change to resources, templates, template variables, chunks, snippets and plugins.
https://modmore.com/extras/versionx/
40 stars 20 forks source link

MODX 3.0.1-pl - chunks and snippets versions not saved #121

Closed deJaya closed 2 years ago

deJaya commented 2 years ago

I’ve checked against four different MODX 3.0.1-pl sites and all of them fail to save new versions [via VersionX] when Chunks or Snippets are saved.

Resource versions are saved OK.

When saving a Chunk or Snippet - one or more of the following errors are logged:

[2022-07-01 20:15:05] (ERROR @ /home/xxyyzz/core/components/versionx/model/versionx.class.php : 318) PHP warning: Object of class MODX\Revolution\mysql\modSnippet could not be converted to int [2022-07-01 20:15:21] (ERROR @ /home/xxyyzz/core/components/versionx/model/versionx.class.php : 279) PHP warning: Object of class MODX\Revolution\mysql\modChunk could not be converted to int [2022-07-01 20:15:21] (ERROR @ /home/xxyyzz/core/components/versionx/elements/plugins/versionx.plugin.php : 117) undefined error

VersionX is up to date. All sites on PHP 8.1.

deJaya commented 2 years ago

discussion and solutions

Mark-H commented 2 years ago

Fixed in 2.4