modxbot / migrate

A testground for migrating issues and other such fun
0 stars 0 forks source link

Missing thumbnails in Manager media browser #10253

Open leoandrews opened 10 years ago

leoandrews commented 10 years ago

leoandrews created Redmine issue ID 10253

Various sections of the Manager which used to show thumbnails seem not to any more. The problem is most evident in the media browser. It seems that phpthumb is returning a null response but there is nothing in the error logs which shows there to be a problem.

Example URL http://channel27.net/connectors/system/phpthumb.php?src=images%2Fshows%2Fshow--winehousespecial-t.jpg&w=100&h=80&f=png&q=90&far=1&HTTP_MODAUTH=_[suppressed-for-security]_&wctx=mgr&source=1

leoandrews commented 10 years ago

leoandrews submitted:

Bumping this. Would like to see it fixed.

opengeek commented 10 years ago

opengeek submitted:

I cannot reproduce this. Any additional information you can provide might be helpful in helping us diagnose the problem you are experiencing.

leoandrews commented 10 years ago

leoandrews submitted:

So my hunch here is that it's something to do with the fact that somewhere in all the code, it's using shell_exec which is forbidden by anyone who's up on their PHP security.

The canary in the coalmine was this line I recently spotted in my errorlog: [2013-12-08 02:29:44](ERROR @ /__/core/model/phpthumb/phpthumb.functions.php : 474) PHP warning: shell_exec() has been disabled for security reasons

Suhosin disables this, I've noticed. Probably wisely too.

(Adding a note that multiple users are affected - forum post: http://forums.modx.com/thread/87660/missing-thumbnails-in-manager-media-browser)