Setup directory is not removed - Githubissues

ox6a6e created Redmine issue ID 10341

The setup directory is not removed in a rare corner-case installation: core, manager and setup, base directories at different places. I already found the reason and a (possible) fix.

In ‘modx-2.2.10-pl/setup/includes/modinstall.class.php‘:

             /** @var modCacheManager $cacheManager */
             $cacheManager = $modx->getCacheManager();
             if ($cacheManager) {
-                $setupPath = $modx->getOption('base_path').'setup/';
+                $setupPath = MODX_SETUP_PATH;
                 if (!$cacheManager->deleteTree($setupPath,true,false,false)) {
                     $modx->log(modX::LOG_LEVEL_ERROR,$this->lexicon('setup_err_remove'));
                 }

‘base_path’ is the path to the web context that does not need to be part of the setup path. AFAICS, MODX_SETUP_PATH is correct in any case.

see: http://forums.modx.com/thread/87766/

modxbot / migrate

Setup directory is not removed #10341