aws-events: Cannot grant `putEvents` to Service Principals

moelasmar commented 2 months ago

Original issue by @arcrank on 2022-09-16T15:44:27Z

Describe the bug

When trying to grantPutEventsTo an AWS SP, there is a no-op, and no warnings or errors. I would expect if we added a grant to a iam.ServicePrincipal that the underlying grant/policy would be created. We can add an SP to the event bus in the console. Tracing back code I myself didn't necessary find a place where this would have failed, or I would have expected if this was not possible to give a failure message.

Expected Behavior

I would expect the template to have grant policies attached. If for some reason you weren't allowed to add SPs, I would expect a failure message and error.

Current Behavior

Nothing is logged to the terminal when synthing the template snippet is

 "Resources": {
  "bus707364D1": {
   "Type": "AWS::Events::EventBus",
   "Properties": {
    "Name": "MyCustomEventBus"
   },
   "Metadata": {
    "aws:cdk:path": "xxx/bus/Resource"
   }
  },
  "busMyArchiveF1010141": {
   "Type": "AWS::Events::Archive",
   "Properties": {
    "SourceArn": {
     "Fn::GetAtt": [
      "bus707364D1",
      "Arn"
     ]
    },
    "ArchiveName": "MyCustomEventBusArchive",
    "Description": "MyCustomerEventBus Archive",
    "EventPattern": {
     "account": [
      "264988854622"
     ]
    },
    "RetentionDays": 365
   },

Reproduction Steps

    const bus = new events.EventBus(this, 'bus', {
      eventBusName: 'MyCustomEventBus'
    });

    bus.archive('MyArchive', {
      archiveName: 'MyCustomEventBusArchive',
      description: 'MyCustomerEventBus Archive',
      eventPattern: {
        account: [cdk.Stack.of(this).account],
      },
      retention: cdk.Duration.days(365),
    });

    bus.grantPutEventsTo(new iam.ServicePrincipal('lambda.amazonaws.com'));

Possible Solution

No response

Additional Information/Context

No response

CDK CLI Version

2.23.0

Framework Version

No response

Node.js Version

14

OS

MacOs/Linux

Language

Typescript

Language Version

No response

Other information

No response

moelasmar commented 2 months ago

This issue has been queued for processing by our automated system.

moelasmar commented 2 months ago

    ## Issue Processing Complete

    This issue has been processed successfully.

    You can view the processing results here: [Results](https://cdkgithubbugreproducersta-githubissueresultsbucket-anxrgpotfplp.s3.amazonaws.com/moelasmar/CodeQlDemoEcsIssue%2319/moelasmar/CodeQlDemoEcsIssue%2319_results.zip?AWSAccessKeyId=ASIAQUFLP7FHWCMZHTEB&Signature=AHUSP3FD5f2wpk8VOCFGyaFntis%3D&x-amz-security-token=IQoJb3JpZ2luX2VjEK3%2F%2F%2F%2F%2F%2F%2F%2F%2F%2FwEaCXVzLXdlc3QtMiJIMEYCIQCDFVQoz0%2FE9jsWvkDfDHZWRgS7mMF4ZOi5my03w47pXQIhAOe%2FUnlL2TYX9S55Ks7YzbPaBPQaERUoubCVCDzvgbLJKuQECPb%2F%2F%2F%2F%2F%2F%2F%2F%2F%2FwEQABoMMDQzMzA5MzMyODE1IgzHTo5Ud7EwEQ25zgQquARQwTOXrMdzyF3h3y7akHN53z4sgLsNjljfAseWEmWJ%2FUeZGDorlGT1EGiqAjWx4dhjmh7LQnV4d%2FRdSWjpx0SmZiO0%2B1zKf4Gngskf%2B%2B6UemJgKFZqsLvutK0PjAsFeKrBuwwYMB9YoODUuLygVorgZgiA3MpxiQL0DyP%2BmrRg4jrYQPf1jqOpzu3q3%2BQdG27jZ3FKssU2w57rJX6kloudVM5EbXBs98fbiNx5XiVmIZ67saV1ynPnElLD33PSIRqPUMEUQNbR%2FllUS2iYrroD1evVc9OOtdyH0eULLyccUMlSKksbxHDqr44%2BQqVFKIqJgQOSCxMNCIpqE%2Fc%2FjT66B7BkMPV1BtOtQ9HU6LF24r7sU%2FSBV5UNlWRIoTnqy8vKQ1GyzRkX7mjBKkghc4LO%2F7OvqTA7sYLQEf3WSJJyR34ml9LtOQLhxpnS3Pf9yZtjGO%2FsRtovw9rCdSFnI%2FnYGLLYoypE%2BOKG8msU62yQTsidHSI97Fo3DXm6bjhG7M99eolidR102zy9IpvA57HZ0BE0u4z5un46YQvQxZ6oALa6NWi%2FViPy3LheAjrzZcr44C%2BUiAHJcSVVRt9Fhe%2B0BQ5280zbbiUcomDnpCK4mWRL4yGoZX5dWcBI0Z5TwB4qZYLRd1ha0ZZ%2FPLa%2B4GzqmlkEe5aNylZlIEPVQWBl0Ytsi2pK0QjPlJfhLhQUumDdXdXdECkh7jYPDcljlKmm%2BjjF%2BlEjjv3yerLohEIwM8sR146SJDazMN6n0r4GOqYBSfo3wK65HBmeuT8N5q15aei%2BRwzyYeyLDXmQbTBy1NIjS2jN7zbStCNDLVtYV1bICqfr056pAXaih2PcWoDK%2BbmO3xRl8YNX8VIBVeD8kMWZYBrgyjk%2FgG%2FmucSHr9l4TMhFSW29kiXjWNWa%2BgSJ%2BI70X5yHNlnl8%2F2zCSKulErSbWrmMpB%2Bs90TZL21qacW3Zk6dW2ujxjO8fJnWT%2Fia%2BtMvprqxQ%3D%3D&Expires=1742589826)

    *This is an automated message from the GitHub Issue Processor.*

moelasmar / CodeQlDemoEcsIssue