aws-events: Cannot grant `putEvents` to Service Principals

moelasmar commented 2 months ago

Original issue by @arcrank on 2022-09-16T15:44:27Z

Describe the bug

When trying to grantPutEventsTo an AWS SP, there is a no-op, and no warnings or errors. I would expect if we added a grant to a iam.ServicePrincipal that the underlying grant/policy would be created. We can add an SP to the event bus in the console. Tracing back code I myself didn't necessary find a place where this would have failed, or I would have expected if this was not possible to give a failure message.

Expected Behavior

I would expect the template to have grant policies attached. If for some reason you weren't allowed to add SPs, I would expect a failure message and error.

Current Behavior

Nothing is logged to the terminal when synthing the template snippet is

 "Resources": {
  "bus707364D1": {
   "Type": "AWS::Events::EventBus",
   "Properties": {
    "Name": "MyCustomEventBus"
   },
   "Metadata": {
    "aws:cdk:path": "xxx/bus/Resource"
   }
  },
  "busMyArchiveF1010141": {
   "Type": "AWS::Events::Archive",
   "Properties": {
    "SourceArn": {
     "Fn::GetAtt": [
      "bus707364D1",
      "Arn"
     ]
    },
    "ArchiveName": "MyCustomEventBusArchive",
    "Description": "MyCustomerEventBus Archive",
    "EventPattern": {
     "account": [
      "264988854622"
     ]
    },
    "RetentionDays": 365
   },

Reproduction Steps

    const bus = new events.EventBus(this, 'bus', {
      eventBusName: 'MyCustomEventBus'
    });

    bus.archive('MyArchive', {
      archiveName: 'MyCustomEventBusArchive',
      description: 'MyCustomerEventBus Archive',
      eventPattern: {
        account: [cdk.Stack.of(this).account],
      },
      retention: cdk.Duration.days(365),
    });

    bus.grantPutEventsTo(new iam.ServicePrincipal('lambda.amazonaws.com'));

Possible Solution

No response

Additional Information/Context

No response

CDK CLI Version

2.23.0

Framework Version

No response

Node.js Version

14

OS

MacOs/Linux

Language

Typescript

Language Version

No response

Other information

No response

moelasmar commented 2 months ago

This issue has been queued for processing by our automated system.

moelasmar commented 2 months ago

    ## Issue Processing Complete

    This issue has been processed successfully.

    You can view the processing results here: [Results](https://cdkgithubbugreproducersta-githubissueresultsbucket-anxrgpotfplp.s3.amazonaws.com/moelasmar/CodeQlDemoEcsIssue%235.txt?AWSAccessKeyId=ASIAQUFLP7FHVF6E5H6V&Signature=%2B7aqVHO8hgarKm9GlSVF6qcIuo0%3D&x-amz-security-token=IQoJb3JpZ2luX2VjEJ%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2FwEaCXVzLXdlc3QtMiJHMEUCIQDDjK0JS%2Bf8ClAWD94EpyEG9ZFOZEvRvAEEQ%2F4%2BHSu44AIgYuifFLCD1FnWwrsRy5YamcmolJaOpYXZusUtH41ahwQq5AQI6P%2F%2F%2F%2F%2F%2F%2F%2F%2F%2FARAAGgwwNDMzMDkzMzI4MTUiDFFtdBtSu7rO3Lzhxyq4BOb8SUgt4uwe1ymfeg7C76O2G%2FNpzaEH0Wcnf%2F9rqAucnSfa6wlnXhdrrFo8KsmNs2ielSSw8KJdKwjN11PK2SuWUk30AARxlUGmqYSa9iw%2BmtY2T1LuXmRXiOq8nyE2SA1wdXUy3HMpmSQqVDSdOGnhATms1nMv2AWZiLnTiYwqSCqz6ngq0U7kRRbkHUWF3cfnnO%2Fuhbn3BlQabou3V%2Fes4YFBZn5AXJ2y%2FAhv3qskYac9dCxA11M1Qe30q2Ourw6r6LGHU%2BgP8E7zOjFC%2FiqNq8bAUBs7rFcEcxbmFxH9bvq9J4ZxDKj0dZpgDzqEy0GmXnZbxSUzyS6GP4jV%2BbLckj%2BFR9t8a%2BJxf9v6x7aeFxXjcK8DKsDylrC%2BSJnSZ14Xdtz989DlBRKPmiIP8aejYDx2n12cTABQztZoiUJ8DaXumypB%2B8Q5tgWGOVOVINYkRlWx4oKrl5iKrMfNpTdCU5WPKKEUb4SbH1LH1v2OFtHgSQioTHuuU8fOkJR1R8Ii%2FuEfkxmK3rMRCoU0odbkl5GX1YnWYJkY8mIB6yKCL1%2B14GSAZBdofaPhSAL5c75YrYSh5lO9Gza63R%2FSSuD7oDCJVJNe%2Fy%2FjzOdYew1jEf2Fi%2F%2FzscO50UdBu5%2B4f%2FUoQugwBgJcIFD8G1is402k5IKDvKk3zKjoDGlDPjrNhes5mvoQ6uIS91A0LhFIr6hzP0zxiNaewu0gZA2W5SAz%2F7gBAPzD8ZqTH9MOE4Q4hdTuJIdc%2BlgwpaHPvgY6pwHC3ixaPcLGkQWl2LBZB13mcvEBLxaST7qSj7%2BrG9SGDJdKrtbDo2AKHmblaKuOh%2FxVzEHb%2FEZcryM6oXwBr3m7dYKrro8MM5PCCAQo%2FZGdgwfacyFdJ2SY2SC1AAsp%2BFjsGstAodIBNegUe0RsPEvVZZRIF1zf08raDDALPzJ1VdtRsMhsDO2rsP0D6P2nXoX7FnlWkqok%2BamTtcGdUA0h%2Fb4moRy7GA%3D%3D&Expires=1742539578)

    *This is an automated message from the GitHub Issue Processor.*

moelasmar / CodeQlDemoEcsIssue